Add configurable creature base stat max value#755
Open
Green00101 wants to merge 2 commits intoPokemonWorkshop:developfrom
Open
Add configurable creature base stat max value#755Green00101 wants to merge 2 commits intoPokemonWorkshop:developfrom
Green00101 wants to merge 2 commits intoPokemonWorkshop:developfrom
Conversation
Aelysya
reviewed
Apr 27, 2026
Collaborator
Aelysya
left a comment
Aelysya
left a comment
There was a problem hiding this comment.
Hello, thanks a lot for your contribution, I've tested and it seems to work fine 😄.
I've left some review comments, just some quick things you could have hardly known since it's your first contribution here so no big deal, great job 😄.
Author
|
Thank you for the review!
Please let me know if there is anything else I need to change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pokémon Studio repo.
Before submitting this PR into the develop branch, please make sure:
Description
Fixes #741
This PR adds a configurable creature base stat limit, with a default maximum value of 999.
Main changes:
baseStatMaxValueto the project settings configuration.999for the maximum base stat value.255value.Note before testing
Existing projects should be migrated automatically. After migration,
baseStatMaxValueshould be added to the project settings with the default value of999.Tests to perform
Sorry, I’m not sure what I should put here.
I tested this change with both a newly created project and an existing project, and both worked as expected.
Thank you for taking the time to review this PR.
I am still learning, so any feedback is welcome. I am happy to update the code if changes are needed.